Not all constants in `fcntl` are available on macos #6807

sobolevn · 2022-01-04T09:05:56Z

Let's try this combination

AlexWaygood · 2022-01-04T09:40:56Z

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu". I think if you want to say "only present on [grab-bag of miscellaneous linux systems]", you need to say if sys.platform != "win32" and sys.platform != "darwin"

stdlib/fcntl.pyi

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

sobolevn · 2022-01-04T09:43:50Z

Maybe we should add some extra OS to the test? We can't do that natively, but I can add some docker-container tests 🤔

I will add an issue for that.

github-actions · 2022-01-04T09:49:10Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli · 2022-01-04T16:17:47Z

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu".

This isn't correct. if sys.platform == "linux" is the correct check for "only present on Ubuntu", and also "present on all linux distros". A check like if sys.platform != "win32" and sys.platform != "darwin" will also be true on other posix systems than linux and macos, such as BSD and Solaris, so it isn't the right choice for linux-specific things.

AlexWaygood · 2022-01-04T16:19:40Z

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu".

This isn't correct. if sys.platform == "linux" is the correct check for "only present on Ubuntu", and also "present on all linux distros". A check like if sys.platform != "win32" and sys.platform != "darwin" will also be true on other posix systems than linux and macos, such as BSD and Solaris, so it isn't the right choice for linux-specific things.

Thanks for the correction!

srittau

I didn't double check in depth, but LGTM.

sobolevn added 3 commits January 4, 2022 12:05

Not all constants in fcntl are available on macos

383602d

Update darwin.txt

159aa94

Update linux.txt

122b16a